feat(resolve): allow overriding enhanced-resolve's options #384
Conversation
GertSallaerts
changed the title
scagood
added
enhancement
typescript
accepted
rule:update
|
Thank you for you PR! I will review it first thing tomorrow morning. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
GertSallaerts
changed the title
|
|
||
| Override the options generated by this plugin for resolving require and import statements. These | ||
| options are passed down to `enhanced-resolve`'s factory method and are documented [here on their | ||
| GitHub repository](https://github.com/webpack/enhanced-resolve?tab=readme-ov-file#resolver-options). |
There was a problem hiding this comment.
I'm a bit concerned that this will over-bind this package to enhanced-resolve, which may make it harder for us to make changes in the future - e.g. moving to import.meta.resolve (which I remember it has been discussed somewhere before).
We can state the minimum necessary in the docs. wdty?
There was a problem hiding this comment.
I guess the minimum necessary really depends on everyone's specific use cases. For us (and why I made this PR) it would be specifying resolverConfig.modules to add an additional path for modules lookup. For another user it might be any of the 25 options documented in enhanced-resolve's README.
Or did you mean something else by the minimum neccesary?
There was a problem hiding this comment.
yes, I think resolverConfig.modules is enough for now. I don't feel that the implementation has to be changed as well - other options can be something like undocumented features. thoughts? /cc @scagood
Allows you to customize the config for module resolution. See: https://github.com/webpack/enhanced-resolve?tab=readme-ov-file#resolver-options
Old description (the PR was initially intended to only specify the
modulesoption)Allows you to do things like:
srcfolder as amodulesfolder andrequire('models/foo');from within yoursrcfolderBasically this: https://webpack.js.org/configuration/resolve/#resolvemodules
That second bullet point used to be possible by just setting
resolvePathsbut going from this comment on #139 that was considered an unintended side-effect or bug.